New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(media-query): fix #187, fixed for platform-server/universal #346

Closed

ardatan wants to merge 2 commits into angular:master from ardatan:master

ardatan commented Jul 23, 2017

Now it gets document object from platform-browser by DI instead of global.


          fix(media-query): fix #187, fixed for platform-server/universal

804d1e5

Collaborator

googlebot commented Jul 23, 2017

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

googlebot added the cla: no label

Author

ardatan commented Jul 23, 2017

I signed it!

Collaborator

googlebot commented Jul 23, 2017

CLAs look good, thanks!

googlebot added cla: yes and removed cla: no labels


          Modified for lint

2776ea6

antonioparraga commented Jul 26, 2017

Please approve this guy!!!!!

Contributor

ThomasBurleson commented Jul 29, 2017

@aparraga - testing is in-progress.

ThomasBurleson added a commit that referenced this pull request


          fix(lib, media-query): use getDom() for platform-server/universal fixes

83690a0

Now gets document object from platform-browser by DI instead of global.

> Thx to @ardatan for PR #346.

Fixes #187. Closes #346.

ThomasBurleson mentioned this pull request

fix(lib, media-query): support angular/universal #353

Merged

Contributor

ThomasBurleson commented Jul 29, 2017

Closing. See PR #353

ThomasBurleson closed this

ThomasBurleson added a commit that referenced this pull request


          fix(lib, media-query): use getDom() for platform-server/universal fixes

d586581

Now gets document object from platform-browser by DI instead of global.

> Thx to @ardatan for PR #346.

Fixes #187. Closes #346.

ThomasBurleson added a commit that referenced this pull request


          fix(lib, media-query): use getDom() for platform-server/universal fixes

94d4c95

Now gets document object from platform-browser by DI instead of global.

> Thx to @ardatan for PR #346.

Fixes #187. Closes #346.

ThomasBurleson added a commit that referenced this pull request


          fix(lib, media-query): use getDom() for platform-server/universal fixes

c2e03f2

Now gets document object from platform-browser by DI instead of global.

> Thx to @ardatan for PR #346.

Fixes #187. Closes #346.

ThomasBurleson added a commit that referenced this pull request


          fix(lib, media-query): use getDom() for platform-server/universal fixes

4425a1a

Now gets document object from platform-browser by DI instead of global.

> Thx to @ardatan for PR #346.

Fixes #187. Closes #346.

ThomasBurleson added a commit that referenced this pull request


          fix(lib, media-query): use getDom() for platform-server/universal fixes

f5cf9e9

Now gets document object from platform-browser by DI instead of global.

> Thx to @ardatan for PR #346.

Fixes #187. Closes #346.

ThomasBurleson added a commit that referenced this pull request


          fix(lib, media-query): use getDom() for platform-server/universal fixes

d3acdbe

Now gets document object from platform-browser by DI instead of global.

> Thx to @ardatan for PR #346.

Fixes #187. Closes #346.

ThomasBurleson added a commit that referenced this pull request


          fix(lib, media-query): use getDom() for platform-server/universal fixes

1f62f0c

Now gets document object from platform-browser by DI instead of global.

> Thx to @ardatan for PR #346.

Fixes #187. Closes #346.

antonioparraga commented Jul 31, 2017

When do you expect to release this guy?

Contributor

ThomasBurleson commented Jul 31, 2017

Beta.9 should be released within the next 10 days... Dependent on 1-3 critical bug fixes remaining.

ThomasBurleson added a commit that referenced this pull request


          fix(lib, media-query): support angular/universal

534f14c

Use getDom() for platform-server/universal fixes
Now gets document object from platform-browser by DI instead of global.

> Thx to @ardatan for PR #346.

Fixes #187, #354. Closes #346.

ThomasBurleson added a commit that referenced this pull request


          fix(lib, media-query): support angular/universal

56a53f6

Use getDom() for platform-server/universal fixes
Now gets document object from platform-browser by DI instead of global.

> Thx to @ardatan for PR #346.

Fixes #187, #354. Closes #346.

ThomasBurleson added a commit that referenced this pull request


          fix(lib, media-query): support angular/universal

7311f99

Use getDom() for platform-server/universal fixes
Now gets document object from platform-browser by DI instead of global.

> Thx to @ardatan for PR #346.

Fixes #187, #354. Closes #346.

ThomasBurleson added a commit that referenced this pull request


          fix(lib, media-query): support angular/universal

f8f56f3

Use getDom() for platform-server/universal fixes
Now gets document object from platform-browser by DI instead of global.

> Thx to @ardatan for PR #346.

Fixes #187, #354. Closes #346.

tinayuangao pushed a commit that referenced this pull request


          fix(lib, media-query): support angular/universal (#353)

0f13b14

Use getDom() for platform-server/universal fixes
Now gets document object from platform-browser by DI instead of global.

> Thx to @ardatan for PR #346.

Fixes #187, #354. Closes #346.

angular-automatic-lock-bot bot commented Sep 5, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

angular-automatic-lock-bot bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels